From: Andrew Morton To: Jan Engelhardt Cc: olaf+list.linux-kernel@olafdietsche.de, eike-kernel@sf-tec.de, linux-kernel@vger.kernel.org Date: Mon, 30 Jan 2006 01:32:14 -0800 Subject: Re: [PATCH 2.6.16-rc1-git4] accessfs: a permission managing filesystem Jan Engelhardt wrote: > > >> >> +static DECLARE_MUTEX(accessfs_sem); > >> > > >> >Please use a `struct mutex'. > >> > >> You know what's irritating? That DECLARE_MUTEX starts a semaphore and > >> DEFINE_MUTEX a mutex. > > > >DECLARE_MUTEX will go away. > > And be replaced by... DEFINE_SEMAPHORE? That would be logical.